[Translation] added Base Exception for the component. #20012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aitboudad
commented
Sep 21, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
xabbuh
requested changes
Sep 21, 2016
| @@ -202,7 +202,7 @@ private function getSchema($xliffVersion) | |||
| $schemaSource = file_get_contents(__DIR__.'/schema/dic/xliff-core/xliff-core-2.0.xsd'); | |||
| $xmlUri = 'informativeCopiesOf3rdPartySchemas/w3c/xml.xsd'; | |||
| } else { | |||
| throw new \InvalidArgumentException(sprintf('No support implemented for loading XLIFF version "%s".', $xliffVersion)); | |||
| throw new InvalidArgumentException(sprintf('No support implemented for loading XLIFF version "%s".', $xliffVersion)); | |||
There was a problem hiding this comment.
use statement is missing, isn't it?
There was a problem hiding this comment.
fixed thanks, FYI I updated the docblock too @throws InvalidArgumentException
There was a problem hiding this comment.
Are there other @throws annotation that need to be updated accordingly?
There was a problem hiding this comment.
yes updated all needed ones
0fa2bce to
0fa4397
Compare
xabbuh
approved these changes
Sep 21, 2016
|
👍 Status: Reviewed |
|
Thank you @aitboudad. |
fabpot
added a commit
that referenced
this pull request
Sep 21, 2016
…(aitboudad) This PR was merged into the 3.2-dev branch. Discussion ---------- [Translation] added Base Exception for the component. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- 0fa4397 [Translation] added Base Exception for the component.
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Mar 17, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Fix translation dep constraint | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a The framework Translator makes use of the Translator component domain exceptions which exist since 3.2 only, leading to a fatal error when one of these exceptions is thrown in the framework using `symfony/translations:<3.2`. Bug introduced in #20012 Commits ------- e1caf7d [FrameworkBundle] Fix translation dep constraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.