[FrameworkBundle] Add phpstorm ide #20019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enumag
reviewed
Sep 22, 2016
| @@ -100,6 +100,7 @@ public function load(array $configs, ContainerBuilder $container) | |||
| 'macvim' => 'mvim://open?url=file://%%f&line=%%l', | |||
| 'emacs' => 'emacs://open?url=file://%%f&line=%%l', | |||
| 'sublime' => 'subl://open?url=file://%%f&line=%%l', | |||
| 'phpstorm' => 'pstorm://open/?url=file://%%f&line=%%l', | |||
There was a problem hiding this comment.
Is the slash before "?" necessary?
There was a problem hiding this comment.
I created PR aik099/PhpStormProtocol#19
There was a problem hiding this comment.
Fixed in aik099/PhpStormProtocol#20
|
Thank you @hason. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add phpstorm ide | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Works on Windows, Mac (https://github.com/aik099/PhpStormProtocol) and Linux (sanduhrs/phpstorm-url-handler@8f7a8df). Commits ------- 450c37c [FrameworkBundle] Add phpstorm ide
Merged
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 22, 2016
This PR was merged into the master branch. Discussion ---------- Updated the framework.ide description - PHPStorm was added here but it was never documented: symfony/symfony#20019 - PhpStormProtocol is not only needed for Windows: https://github.com/aik099/PhpStormProtocol Commits ------- b619fc2 Updated the framework.ide description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on Windows, Mac (https://github.com/aik099/PhpStormProtocol) and Linux (sanduhrs/phpstorm-url-handler@8f7a8df).