[Form] Change FormTypeGuesserChain to accept Traversable #20047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Sep 24, 2016
| foreach ($guessers as $guesser) { | ||
| if (!$guesser instanceof FormTypeGuesserInterface) { | ||
| throw new UnexpectedTypeException($guesser, 'Symfony\Component\Form\FormTypeGuesserInterface'); | ||
| throw new UnexpectedTypeException($guesser, FormTypeGuesserInterface::class); |
There was a problem hiding this comment.
It seemed logical to make this change but if you say so... reverted.
There was a problem hiding this comment.
Problem is that's causing merge conflicts when merging older branches in the newer onces.
There was a problem hiding this comment.
Oh. That explains why Symfony still uses the old array syntax too. Thank you!
|
@fabpot Anything else to do here? |
|
Thank you @enumag. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2016
…le (enumag) This PR was merged into the 3.2-dev branch. Discussion ---------- [Form] Change FormTypeGuesserChain to accept Traversable | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I'm using symfony/form without the rest of the framework and this will make things a bit easier for me. Commits ------- 5e4f4d4 [Form] Change FormTypeGuesserChain to accept Traversable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using symfony/form without the rest of the framework and this will make things a bit easier for me.