[FrameworkBundle] fix yaml:lint when yaml is not installed along side framework-bundle #20066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50c6de0 to
8fe497c
Compare
xabbuh
reviewed
Sep 28, 2016
| parent::configure(); | ||
| $this->setName('lint:yaml'); | ||
|
|
||
| if (!$this->isEnabled() && null !== $this->command) { |
There was a problem hiding this comment.
Do we need this? configure() should never be called if the command is not enabled.
There was a problem hiding this comment.
Yes, this is needed as configure() is called by the constructor.
chalasr
reviewed
Sep 28, 2016
| private $directoryIteratorProvider; | ||
| private $isReadableProvider; | ||
|
|
||
| public function __construct($name = null, $directoryIteratorProvider = null, $isReadableProvider = null) |
There was a problem hiding this comment.
Couldn't $directoryIteratorProvider and $isReadableProvider be type-hinted as callable?
chalasr
reviewed
Sep 28, 2016
| } | ||
|
|
||
| return parent::getDirectoryIterator($directory); | ||
| return class_exists('Symfony\Component\Yaml\Command\LintCommand') && parent::isEnabled(); |
There was a problem hiding this comment.
Could be class_exists(BaseLintCommand::class)
8fe497c to
6d3e5d0
Compare
…de framwork-bundle
6d3e5d0 to
b1c5a68
Compare
fabpot
added a commit
that referenced
this pull request
Sep 28, 2016
… along side framework-bundle (fabpot) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] fix yaml:lint when yaml is not installed along side framework-bundle | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a YAML is not an explicit dependency of FrameworkBundle. If it is not installed, the console is broken as the yaml:lint commands tries to extends the one in the YAML component. This bug only exists in master as this refactoring happened in 3.2 Commits ------- b1c5a68 [FrameworkBundle] fixed yaml:lint when yaml is not installed along side framwork-bundle
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML is not an explicit dependency of FrameworkBundle. If it is not installed, the console is broken as the yaml:lint commands tries to extends the one in the YAML component. This bug only exists in master as this refactoring happened in 3.2