[FrameworkBundle] removed the Asset component dependency on FrameworkBundle #20067
Conversation
4a6cd91 to
c2ddb68
Compare
|
👍 By the way, I do not think that this change will not be breaking some applications. In my experience there are way to many packages out there that require the FrameworkBundle instead of explicitly listing their dependencies. Probably, not many of them will break because of the missing Asset component, but we will probably have to expect some (a lot of) reports when doing similar changes with other component. Though maybe this helps to educate people to be more explicit with what their packages actually really need without pulling the whole universe. |
| { | ||
| if (!class_exists('Symfony\Component\Asset\Package')) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I don't think this command uses anything from the asset component and so could stay enabled if the component isn't installed.
There was a problem hiding this comment.
Oops, you're right, reverted
c2ddb68 to
1dd4e21
Compare
…cy on FrameworkBundle (fabpot) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] removed the Asset component dependency on FrameworkBundle | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no (except for people using FrameworkBundle without requiring symfony/symfony which should be pretty rare; and fixing this is easy by adding symfony/asset explicitly) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15748 partially | License | MIT | Doc PR | n/a Trying to reduce the number of required dependencies on FrameworkBundle. This PR removes the Asset component from the list. Commits ------- 1dd4e21 [FrameworkBundle] removed the Asset component dependency on FrameworkBundle
Trying to reduce the number of required dependencies on FrameworkBundle. This PR removes the Asset component from the list.