[FrameworkBundle] removed the Translation component dependency on FrameworkBundle #20070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Sep 28, 2016
…pendency on FrameworkBundle (fabpot) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] removed the Translation component dependency on FrameworkBundle | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no (except for people using FrameworkBundle without requiring symfony/symfony which should be pretty rare; and fixing this is easy by adding symfony/translation explicitly) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15748 partially | License | MIT | Doc PR | n/a Another PR to reduce the number of required dependencies on FrameworkBundle. This PR removes the Translation component from the list. Commits ------- a496a2a [FrameworkBundle] removed the Translation component dependency on FrameworkBundle
Koc
reviewed
Sep 28, 2016
| @@ -87,6 +87,18 @@ protected function configure() | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function isEnabled() | |||
| { | |||
| if (!class_exists('Symfony\Component\Translation\Translator')) { | |||
There was a problem hiding this comment.
You can use ::class notation here
stof
reviewed
Sep 30, 2016
| @@ -85,8 +85,10 @@ public function build(ContainerBuilder $container) | |||
| $container->addCompilerPass(new AddCacheWarmerPass()); | |||
| $container->addCompilerPass(new AddCacheClearerPass()); | |||
| $container->addCompilerPass(new AddExpressionLanguageProvidersPass()); | |||
| $container->addCompilerPass(new TranslationExtractorPass()); | |||
| $container->addCompilerPass(new TranslationDumperPass()); | |||
| if (class_exists('Symfony\Component\Translation\Translator')) { | |||
There was a problem hiding this comment.
all other compiler passes are always registered, and return early when the service does not exist (accounting for disabling by configuration too). Shouldn't it be done here too ?
There was a problem hiding this comment.
And for those as well. It was more about not even registering them if the translation component is not installed. But that's probably not really needed as this is for build only. I'm going to revert this change.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR to reduce the number of required dependencies on FrameworkBundle. This PR removes the Translation component from the list.