Skip to content

[FrameworkBundle] removed the Security Core and Security CSRF component dependencies on FrameworkBundle #20075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2016

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 28, 2016

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no (except for people using FrameworkBundle without requiring symfony/symfony which should be pretty rare; and fixing this is easy by adding symfony/security-core and symfony/security-csrf explicitly)
Deprecations? no
Tests pass? yes
Fixed tickets #15748 partially
License MIT
Doc PR n/a

Another PR to reduce the number of required dependencies on FrameworkBundle. This PR removes the Security Core and CSRF components from the list.

@fabpot fabpot merged commit d703784 into symfony:master Sep 28, 2016
fabpot added a commit that referenced this pull request Sep 28, 2016
…ty CSRF component dependencies on FrameworkBundle (fabpot)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[FrameworkBundle] removed the Security Core and Security CSRF component dependencies on FrameworkBundle

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no (except for people using FrameworkBundle without requiring symfony/symfony which should be pretty rare; and fixing this is easy by adding symfony/security-core and symfony/security-csrf explicitly)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15748 partially
| License       | MIT
| Doc PR        | n/a

Another PR to reduce the number of required dependencies on FrameworkBundle. This PR removes the Security Core and CSRF components from the list.

Commits
-------

d703784 [FrameworkBundle] removed the Security Core and Security CSRF component dependencies on FrameworkBundle
@fabpot fabpot deleted the security-dep-frameworkbundle branch October 1, 2016 05:07
@fabpot fabpot mentioned this pull request Oct 27, 2016
xabbuh added a commit to xabbuh/symfony that referenced this pull request May 15, 2017
These requirements have been moved in symfony#20075 before and are still
present in the `require-dev` section.
xabbuh added a commit to xabbuh/symfony that referenced this pull request May 15, 2017
These requirements have been moved in symfony#20075 before and are still
present in the `require-dev` section.
fabpot added a commit that referenced this pull request May 15, 2017
…ction (xabbuh)

This PR was merged into the 3.2 branch.

Discussion
----------

[FrameworkBundle] remove Security deps from the require section

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

These requirements have been moved in #20075 before and are still
present in the `require-dev` section.

see symfony/flex#14

Commits
-------

c690256 remove Security deps from the require section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants