Skip to content

fixed Twig support for 1.26 and 2.0 #20079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2016
Merged

fixed Twig support for 1.26 and 2.0 #20079

merged 1 commit into from
Sep 29, 2016

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Sep 28, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Removes the deprecation notices for Twig 1.26.

@fabpot fabpot merged commit 24e9cf2 into symfony:2.7 Sep 29, 2016
fabpot added a commit that referenced this pull request Sep 29, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

fixed Twig support for 1.26 and 2.0

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Removes the deprecation notices for Twig 1.26.

Commits
-------

24e9cf2 fixed Twig support for 1.26 and 2.0
@fabpot fabpot deleted the twig-upgrade branch October 1, 2016 05:07
@ro0NL
Copy link
Contributor

ro0NL commented Oct 2, 2016

@fabpot this breaks deps.. there is no stable 1.26 release, only 1.26@dev.

Problem 1
  - symfony/symfony 3.2.x-dev requires twig/twig ~1.26|~2.0 -> satisfiable by twig/twig[1.x-dev, 2.0.x-dev] but these conflict with your requirements or minimum-stability.
UndefinedMethodException in appDevDebugProjectContainer.php line 3154:
Attempted to call an undefined method named "addRuntimeLoader" of class "Twig_Environment".

edit: i worked around it using composer require twig/twig:@dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants