Skip to content

[2.7][Console] consistent application help with 3.2 #20090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[2.7][Console] consistent application help with 3.2 #20090

wants to merge 1 commit into from

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Sep 29, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17804, #19181, partially #20030
License MIT
Doc PR reference to the documentation PR, if any

Fix from #16906 that should have targeted 2.7 as well imo.

2.7 / before

$ app/console -h
Usage:
  help [options] [--] [<command_name>]
  ^ list is the default command...
Arguments:
  command                  The command to execute
  ^ The problem
  command_name             The command name [default: "help"]

Options:
      --xml                To output help as XML
      --format=FORMAT      The output format (txt, xml, json, or md) [default: "txt"]
      --raw                To output raw command help
  -h, --help               Display this help message
  -q, --quiet              Do not output any message
  -V, --version            Display this application version
      --ansi               Force ANSI output
      --no-ansi            Disable ANSI output
  -n, --no-interaction     Do not ask any interactive question
  -s, --shell              Launch the shell.
      --process-isolation  Launch commands from shell as a separate process.
  -e, --env=ENV            The Environment name. [default: "dev"]
      --no-debug           Switches off debug mode.
  -v|vv|vvv, --verbose     Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

2.7 / after

$ app/console -h
Usage:
  list [options] [--] [<namespace>]

Arguments:
  namespace            The namespace name

Options:
      --xml            To output list as XML
      --raw            To output raw command list
      --format=FORMAT  The output format (txt, xml, json, or md) [default: "txt"]

master / current

$ bin/console -h
Usage:
  list [options] [--] [<namespace>]

Arguments:
  namespace            The namespace name

Options:
      --raw            To output raw command list
      --format=FORMAT  The output format (txt, xml, json, or md) [default: "txt"]

Also shows the problem with ListCommand::getNativeDefinition as now the options are incorrect. Fixed that in #20054.. so these should probably both go on 2.7.

Hopes this makes it clear.

@ro0NL
Copy link
Contributor Author

ro0NL commented Sep 29, 2016

ping @lyrixx :)

edit: #16906 (comment) what happened?

@lyrixx
Copy link
Member

lyrixx commented Sep 30, 2016

@ro0NL I dont understand what you expect from me.

@ro0NL
Copy link
Contributor Author

ro0NL commented Sep 30, 2016

Can you conform this should be applied on 2.7?

@lyrixx
Copy link
Member

lyrixx commented Sep 30, 2016

No I can't. I think it could be considered as a BC break. But I'm not sure.
So +0 for me

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 7, 2016

@fabpot do you qualify this a bugfix? Im not sure the difference is intended.. Otherwise lets close it :) As (to me) 3.2 has the correct behavior already (which was also a BC break then?)

@fabpot
Copy link
Member

fabpot commented Nov 7, 2016

I would prefer to close it as this is technically a BC break, and anyway, that does not fix a problem, so there is no need to "fix" it :)

@fabpot fabpot closed this Nov 7, 2016
@ro0NL ro0NL deleted the console/default-help branch November 7, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants