hm somehow the first commit from #20080 is missing here?

Could be related to the revert?

yes but how do i get it back, do i need to make a new commit or can this just be merged manually via cherrypicking?

try to amend it to change its hash

have rebased it onto current 2.7 and collapsed both commits

@fabpot you have added this bugfix to the 2.7.19 tag, though you reverted the first PR, pls check this one, as the failing test cases are fixed, maybe @webmozart should also review this

@backbone87 since you modify abstract tests of the Form component, you have to update both TwigBridge and FrameworkBundle dependency to it in their composer.json to ~2.7.20|~2.8.13|~3.1.6.

Be sure to run tests on them before pushing, thanks.

OK, I confirm tests are green.

Status: Reviewed

i would still recommend to wait for a review of @webmozart

consider the following usecase:

$form = $factory->create(FormType::class, [ 'items' => [] ]);
$form->add('items', CollectionType::class, [ 'entry_type' => TextType::class ]);

and the following tpl:

{{ form_start(form) }}
  {{ form_errors(form) }}
  {{ form_row(form.items) }}
{{ form_end(form) }}

with this change {{ form_row(form.items) }} will not output anything, because form.items.rendered is true and https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/FormRenderer.php#L158 prevents rendering of form views, that are already rendered (either explicitly or implicitly). I dont think the behavior of the renderer is good in this case. If i request form.items to be rendered explicitly, i dont want the renderer to deny that because of some internal state.

also see #20080 (comment) for more

Status: Needs Work

Sorry I've got the message with delay, yes the choice type is definitely a problem, let's solve this with #17609 instead.

@backbone87 @HeahDude what's the status here? (rebase needed)

Closing as there is no more activity.