added checks for public services on compiler passes that use service ids and not references #20112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Sep 30, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
a3c766a to
0f0fa52
Compare
| @@ -231,6 +231,7 @@ public function testRuntimeLoader() | |||
|
|
|||
| $loader = $container->getDefinition('twig.runtime_loader'); | |||
| $args = $loader->getArgument(1); | |||
| print_r($loader->getArguments()); | |||
There was a problem hiding this comment.
This looks like a debug leftover
0f0fa52 to
4166a07
Compare
stof
reviewed
Sep 30, 2016
| throw new InvalidArgumentException(sprintf('The service "%s" must not be abstract as it can be lazy-loaded.', $id)); | ||
| } | ||
|
|
||
| $validators[$definition->getClass()] = $id; |
There was a problem hiding this comment.
shouldn't this be done in older branches ?
…id and not references
4166a07 to
82fa942
Compare
fabpot
added a commit
that referenced
this pull request
Oct 1, 2016
…se service ids and not references (fabpot) This PR was merged into the 3.2-dev branch. Discussion ---------- added checks for public services on compiler passes that use service ids and not references | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 82fa942 added checks for public services on compiler passes that use service id and not references
Merged
lyrixx
reviewed
Feb 1, 2017
| } | ||
|
|
||
| if ($def->isAbstract()) { | ||
| throw new InvalidArgumentException(sprintf('The service "%s" must not be abstract as it can be lazy-loaded.', $id)); |
There was a problem hiding this comment.
The message here is not very accurate. An abstract service is not "get() able". It's not about lazy-loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.