[TwigBundle] changed the runtime loader to return null if there is no match #20119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
263f637 to
d7b912b
Compare
d7b912b to
c03fd80
Compare
linaori
reviewed
Oct 1, 2016
| return $this->container->get($this->mapping[$class]); | ||
| if (null !== $this->logger) { | ||
| $this->logger->warning(sprintf('Class "%s" is not configured as a Twig runtime. Add the "twig.runtime" tag to the related service in the container.', $class)); | ||
| } |
There was a problem hiding this comment.
What about simply injecting a null/void logger if non is configured?
There was a problem hiding this comment.
Because I don't like forcing using a Logger if not available.
fabpot
added a commit
that referenced
this pull request
Oct 3, 2016
… if there is no match (fabpot) This PR was merged into the 3.2-dev branch. Discussion ---------- [TwigBundle] changed the runtime loader to return null if there is no match | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a ping @stof Commits ------- c03fd80 [TwigBundle] changed the runtime loader to return null if there is no match
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @stof