[DependencyInjection] move tags from decorated to decorating service #20207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 11, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20150 |
| License | MIT |
| Doc PR |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 14, 2016
…ng service (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] move tags from decorated to decorating service | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20150 | License | MIT | Doc PR | Commits ------- 7def83c move tags from decorated to decorating service
fabpot
added a commit
that referenced
this pull request
Oct 23, 2016
…lacing them (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [DependencyInjection] merge tags instead of completely replacing them | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | yes/no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20150, #20207 | License | MIT | Doc PR | In #20207, I missed the `array_merge()` call. Thus, previously set tags of the decorating service would have been discarded by the compiler pass. Commits ------- c333eb7 merge tags instead of completely replacing them
This was referenced Oct 27, 2016
Merged
Merged
Merged
|
NVM, It think was a bad idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.