[Form] render hidden empty inputs for checkboxes #20210
Conversation
|
Looks like not all tests are passing. |
7f6a42c to
b56bf05
Compare
This ensures that a form is always considered submitted even if it contains only checkboxes which all haven't been checked by the user.
|
The hidden input should not be added for expanded multiple choice types |
| @@ -85,7 +85,7 @@ | |||
| {%- endblock choice_widget_options -%} | |||
|
|
|||
| {%- block checkbox_widget -%} | |||
| <input type="checkbox" {{ block('widget_attributes') }}{% if value is defined %} value="{{ value }}"{% endif %}{% if checked %} checked="checked"{% endif %} /> | |||
| <input type="hidden" name="{{ full_name }}" /><input type="checkbox" {{ block('widget_attributes') }}{% if value is defined %} value="{{ value }}"{% endif %}{% if checked %} checked="checked"{% endif %} /> | |||
There was a problem hiding this comment.
just to understand: this will render two input fields with the same name then, right? So if the checkbox is ticked then the browser will send its value as it's a successor in the DOM?
Or will it send both? like name=&name=checkbox_value
|
@backbone87 You are right. Sending the hidden field there too would lead to wrong data. However, this also means that we would not be able to fix the underlying issue in all cases. Question is should we still follow this approach to solve at least some of them? ping @symfony/deciders |
|
i dont even know how to solve the case with extended multiple choice, maybe one hidden input with the "non-array"-name will work, to produce POST data like this: |
|
For the record, we use this approach: http://stackoverflow.com/questions/1809494/post-the-checkboxes-that-are-unchecked#answer-35689714 |
|
another approach to this (which is also used within Contao, though for a different purpose) could be a separate POST variable containing submitted fields.
this would then be handled within the RequestHandler $data = $_POST[$name];
foreach($_POST['_submitted'] as $path) {
$propertyAccessor->setValue($data, $path, null);
}´ the benefit of this is the full transparency for any form type, because the root cause of this problem is the application/www-url-form-encoded can only work with strings and arrays/maps and no other data type (like application/json) |
|
I think we can close here in favor of #17771. |
|
Closing in favour of #17771. |
This ensures that a form is always considered submitted even if it contains only checkboxes which all haven't been checked by the user.