Trim constant values in XmlFileLoader #20252
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an XML config file gets long, it's nice to put the constant name into the next line like this:
```xml
<parameter key="som_very_very_long_constant_name" type="constant">
Some\Namespace\That\Is\Sufficiently\Long\To\Require\A\LineBreak::someLongishConstantName
</parameter>
```
If that’s the case, `constant()` will try and find a constant including the spaces. While it is theoretically possible to have a constant in PHP that starts or ends with a space, it’s impossible for class constants and only doable using `define(" FOO ", …);`. So that’s probably an edge case we can ignore.
ro0NL
reviewed
Oct 19, 2016
| @@ -391,7 +391,7 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $lowercase = true) | |||
| $arguments[$key] = $arg->nodeValue; | |||
| break; | |||
| case 'constant': | |||
| $arguments[$key] = constant($arg->nodeValue); | |||
| $arguments[$key] = constant(trim(arg->nodeValue)); | |||
|
@ro0NL 👍 |
|
you forgot to commit utest for a change ;) |
|
LGTM, should be merged in 2.7. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @lstrojny. |
fabpot
added a commit
that referenced
this pull request
Oct 22, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20252). Discussion ---------- Trim constant values in XmlFileLoader | Q | A | ------------- | --- | Branch? | 2.7, 2.8, 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n.A. | License | MIT | Doc PR | n.A. When an XML config file gets long, it's nice to put the constant name into the next line like this: ```xml <parameter key="som_very_very_long_constant_name" type="constant"> Some\Namespace\That\Is\Sufficiently\Long\To\Require\A\LineBreak::someLongishConstantName </parameter> ``` If that’s the case, `constant()` will try and find a constant including the spaces. While it is theoretically possible to have a constant in PHP that starts or ends with a space, it’s impossible for class constants and only doable using `define(" FOO ", …);`. So that’s probably an edge case we can ignore. Commits ------- f09e621 Trim constant values in XmlFileLoader
This was referenced Oct 27, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an XML config file gets long, it's nice to put the constant name into the next line like this:
If that’s the case,
constant()will try and find a constant including the spaces. While it is theoretically possible to have a constant in PHP that starts or ends with a space, it’s impossible for class constants and only doable usingdefine(" FOO ", …);. So that’s probably an edge case we can ignore.