[PhpUnitBridge] Allow configuring removed deps and phpunit versions #20256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is probably a doc to update somewhere, right? |
stof
reviewed
Oct 20, 2016
| @@ -16,7 +16,7 @@ | |||
| error_reporting(-1); | |||
|
|
|||
| // PHPUnit 4.8 does not support PHP 7, while 5.1 requires PHP 5.6+ | |||
| $PHPUNIT_VERSION = PHP_VERSION_ID >= 50600 ? '5.1' : '4.8'; | |||
There was a problem hiding this comment.
I suggest using 5.3 rather than 5.1, as 5.1 is EOLed (and then, we should start working on making our testsuite compatible with 5.4+ to use supported PHPunit versions)
There was a problem hiding this comment.
Updated to 5.3, all good.
34add38 to
75449c5
Compare
|
Just tried with phpunit 5.3, I have a failure locally. |
|
Failing test spotted, fixed in #20265 |
75449c5 to
fb1c5b8
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 21, 2016
…unit versions (nicolas-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [PhpUnitBridge] Allow configuring removed deps and phpunit versions | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#7074 Allowing greater reuse of the wrapper. Commits ------- fb1c5b8 [PhpUnitBridge] Allow configuring removed deps and phpunit versions
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 26, 2016
…iguration env vars (nicolas-grekas) This PR was merged into the master branch. Discussion ---------- [PhpUnitBridge] Doc for @expectedDeprecation & new configuration env vars Related to symfony/symfony#20255 & symfony/symfony#20256 Commits ------- a1682de [PhpUnitBridge] Doc for @expectedDeprecation & new configuration env vars
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing greater reuse of the wrapper.