[DependencyInjection] Fix FactoryReturnTypePass position in PassConfig #20263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hason
commented
Oct 21, 2016
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19161, #19191 |
| License | MIT |
| Doc PR |
stof
reviewed
Oct 21, 2016
| } else { | ||
| $this->assertEquals('Please add the class to service "factory" even if it is constructed by a factory since we might need to add method calls based on compile-time checks.', $e->getMessage()); | ||
| } | ||
| } |
There was a problem hiding this comment.
this test will not fail if no RuntimeException is thrown, and there is no assertion in this case
stof
reviewed
Oct 21, 2016
| if (method_exists(\ReflectionMethod::class, 'getReturnType')) { | ||
| $this->fail('The FactoryReturnTypePass should set the class to service "factory".'); | ||
| } else { | ||
| $this->assertEquals('Please add the class to service "factory" even if it is constructed by a factory since we might need to add method calls based on compile-time checks.', $e->getMessage()); |
There was a problem hiding this comment.
rather than this, use ->setExpectedException() instead (only on PHP 5) and don't catch the exception. It will avoid the need to fail manually.
|
Thank you @hason. |
fabpot
added a commit
that referenced
this pull request
Oct 21, 2016
…n PassConfig (hason) This PR was merged into the 3.2-dev branch. Discussion ---------- [DependencyInjection] Fix FactoryReturnTypePass position in PassConfig | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19161, #19191 | License | MIT | Doc PR | Commits ------- dfb5cc3 [DependencyInjection] Fix FactoryReturnTypePass position in PassConfig
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.