[TwigBundle] made Twig cache independent of the project root directory #20285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
Oct 24, 2016
…t root directory (fabpot) This PR was merged into the 3.2-dev branch. Discussion ---------- [TwigBundle] made Twig cache independent of the project root directory | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no (except if people configured relative paths instead of absolute ones, but this was not supported in earlier versions of Twig) | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This makes Twig cache keys independent of the project root directory, thanks to Twig 1.27. It cannot be merged in 2.7 as a bug fix as people might have used relative paths for some Twig paths (no officially supported by Twig anyway), which would have resolved to `getcwd()` before, but will now be interpreted as being relative to `%kernel.root_dir%` now. Commits ------- dc38af3 [TwigBundle] made Twig cache independent of the project root directory
Merged
|
|
fabpot
added a commit
that referenced
this pull request
Nov 9, 2016
This PR was merged into the 3.2-dev branch. Discussion ---------- [TwigBundle] fixed template root path | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | see #20285 | License | MIT | Doc PR | n/a Commits ------- 526b8a0 [TwigBundle] fixed template root path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Twig cache keys independent of the project root directory, thanks to Twig 1.27.
It cannot be merged in 2.7 as a bug fix as people might have used relative paths for some Twig paths (no officially supported by Twig anyway), which would have resolved to
getcwd()before, but will now be interpreted as being relative to%kernel.root_dir%now.