Properly format value in UniqueEntityValidator #20287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d57df0d to
3d1fc75
Compare
fabpot
reviewed
Nov 4, 2016
| * This software consists of voluntary contributions made by many individuals | ||
| * and is licensed under the MIT license. For more information, see | ||
| * <http://www.doctrine-project.org>. | ||
| */ |
3d1fc75 to
9f9720e
Compare
xabbuh
reviewed
Nov 5, 2016
| * @return EntityManager | ||
| */ | ||
| public static function createTestEntityManager() | ||
| public static function createTestEntityManager(\Doctrine\ORM\Configuration $config = null) |
There was a problem hiding this comment.
please add a use statement instead of using the FQCN (same in the docblock then)
xabbuh
reviewed
Nov 5, 2016
| { | ||
| if (!extension_loaded('pdo_sqlite')) { | ||
| \PHPUnit_Framework_TestCase::markTestSkipped('Extension pdo_sqlite is required.'); | ||
| } | ||
|
|
||
| if ($config === null) { |
9f9720e to
ed0d3fe
Compare
|
@xabbuh done! |
fabpot
reviewed
Nov 6, 2016
| /** | ||
| * The list of EntityRepository instances. | ||
| * | ||
| * @var \Doctrine\Common\Persistence\ObjectRepository[] |
There was a problem hiding this comment.
As mentioned by @xabbuh, you should use a use statement instead of using the FQCN (there are other occurrences in your patch).
fabpot
reviewed
Nov 6, 2016
| /** | ||
| * Create a new repository instance for an entity class. | ||
| * | ||
| * @param \Doctrine\ORM\EntityManagerInterface $entityManager The EntityManager instance. |
There was a problem hiding this comment.
When the phpdoc does not add any value, it should be removed, which is the case here and the same goes for the next one.
There was a problem hiding this comment.
I'm not sure I understand correctly. Do you mean the method description, parameter description or both?
ed0d3fe to
9043a55
Compare
|
Thank you @alcaeus. |
fabpot
added a commit
that referenced
this pull request
Nov 6, 2016
This PR was merged into the 3.1 branch. Discussion ---------- Properly format value in UniqueEntityValidator | Q | A | | --- | --- | | Branch? | 3.1 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | / | | License | MIT | This PR fixes a small issue introduced in #15279. Having an array in a field considered for a unique check causes an array to string conversion error in the translator. This can be avoided by formatting the value parameter with `formatValue`. Commits ------- 9043a55 Properly format value in UniqueEntityValidator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue introduced in #15279. Having an array in a field considered for a unique check causes an array to string conversion error in the translator. This can be avoided by formatting the value parameter with
formatValue.