Skip to content

Fix edge case with StreamedResponse where headers are sent twice #20289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Fix edge case with StreamedResponse where headers are sent twice #20289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/Symfony/Component/HttpFoundation/StreamedResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class StreamedResponse extends Response
{
protected $callback;
protected $streamed;
private $headersSent;

/**
* Constructor.
Expand All @@ -44,6 +45,7 @@ public function __construct($callback = null, $status = 200, $headers = array())
$this->setCallback($callback);
}
$this->streamed = false;
$this->headersSent = false;
}

/**
Expand Down Expand Up @@ -75,6 +77,22 @@ public function setCallback($callback)
$this->callback = $callback;
}

/**
* {@inheritdoc}
*
* This method only sends the headers once.
*/
public function sendHeaders()
{
if ($this->headersSent) {
return;
}

$this->headersSent = true;

parent::sendHeaders();
}

/**
* {@inheritdoc}
*
Expand Down