Improved the design of the metrics in the profiler #20294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, shouldnt this remove the margin bottom from
and here
The extra space for sub requests to me looks weird, and semi out of place; Imo. separating groups (of metrics) should look different. |
|
@ro0NL you are right about the excessive bottom margin. It has been fixed now. Thanks! About the horizontal divider, I don't agree with you ... but this is design and not code, so people can say opposite things and both be right :) |
|
@ro0NL @javiereguiluz I think the added horizontal space (divider) separation is sensible and clean. 👍 |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Nov 4, 2016
…eguiluz) This PR was squashed before being merged into the 2.8 branch (closes #20294). Discussion ---------- Improved the design of the metrics in the profiler | Q | A | | --- | --- | | Branch? | 2.8 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Tests pass? | yes | | Fixed tickets | - | | License | MIT | | Doc PR | | - Performance panel now displays Sub-Requests a bit separated from the normal metrics - Singular/plural: when there is 1 sub-request, we don't display "sub-request**s**" anymore ### Before  ### After  - Add bottom margin to metrics so they are correctly displayed when the screen is very small. ### Before & After  Commits ------- d030a9d Improved the design of the metrics in the profiler
This was referenced Nov 17, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Before & After