[SecurityBundle] Changed encoder configuration example to bcrypt #20301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -386,9 +386,9 @@ private function addEncodersSection(ArrayNodeDefinition $rootNode) | |||
| ->children() | |||
| ->arrayNode('encoders') | |||
| ->example(array( | |||
| 'Acme\DemoBundle\Entity\User1' => 'sha512', | |||
| 'Acme\DemoBundle\Entity\User1' => 'bcrypt', | |||
There was a problem hiding this comment.
Could we also change the deprecated 'Acme\DemoBundle\Entity\User1' example by 'AppBundle\Entity\User1' ? Thanks!
| 'Acme\DemoBundle\Entity\User2' => array( | ||
| 'algorithm' => 'sha512', | ||
| 'algorithm' => 'bcrypt', | ||
| 'encode_as_base64' => 'true', |
There was a problem hiding this comment.
We need to remove encode_as_base64 and iterations ... but we could add cost
0498f1e to
b2831a9
Compare
|
I made the changes. |
|
status: needs review |
javiereguiluz
approved these changes
Oct 26, 2016
|
What about changing the target branch to 2.7? |
|
Can be done on merge, it's up to you :) |
|
👍 |
|
Thank you @jeremyFreeAgent. |
fabpot
added a commit
that referenced
this pull request
Oct 30, 2016
…o bcrypt (jeremyFreeAgent) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20301). Discussion ---------- [SecurityBundle] Changed encoder configuration example to bcrypt | Q | A | ------------- | --- | Branch? | "master" | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Simple change in the configuration example to help developers to not use `sha512` as encoder when using `config:dump-reference`. Commits ------- a55058f [SecurityBundle] Changed encoder configuration example to bcrypt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change in the configuration example to help developers to not use
sha512as encoder when usingconfig:dump-reference.