[FrameworkBundle] Add --no-prefix option to translation:update #20432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $extractor->setPrefix(null === $prefix ? '' : $prefix); | ||
|
|
||
| if (false === $input->getOption('no-prefix')) { | ||
| $extractor->setPrefix(false === $input->getOption('no-prefix') ? $input->getOption('prefix') : ''); |
There was a problem hiding this comment.
The false === $input->getOption('no-prefix') condition is redundant here?
| @@ -39,6 +39,7 @@ protected function configure() | |||
| new InputArgument('locale', InputArgument::REQUIRED, 'The locale'), | |||
| new InputArgument('bundle', InputArgument::OPTIONAL, 'The bundle name or directory where to load the messages, defaults to app/Resources folder'), | |||
| new InputOption('prefix', null, InputOption::VALUE_OPTIONAL, 'Override the default prefix', '__'), | |||
| new InputOption('no-prefix', null, InputOption::VALUE_NONE, 'Should the prefix be an empty string'), | |||
There was a problem hiding this comment.
Maybe we could reword this description as: If set, no prefix is added to the translations.
There was a problem hiding this comment.
Updated, thank you @javiereguiluz
6e318d5 to
53ed38f
Compare
xabbuh
reviewed
Nov 7, 2016
| $extractor = $this->getContainer()->get('translation.extractor'); | ||
| $extractor->setPrefix(null === $prefix ? '' : $prefix); | ||
| $extractor->setPrefix(false === $input->getOption('no-prefix') ? $input->getOption('prefix') : ''); |
There was a problem hiding this comment.
I think $input->getOption('no-prefix') ? '' : $input->getOption('prefix') will be more readable.
53ed38f to
914e3a9
Compare
Remove ending dot from option description for consistency
914e3a9 to
b5a1584
Compare
|
👍 |
1 similar comment
|
👍 |
|
Is this planed for 3.2? An unsuccessful fix being released and finally reverted, I think the earlier possible would be the best. |
|
👍 |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Nov 11, 2016
…date (chalasr) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Add --no-prefix option to translation:update | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20044 | License | MIT | Doc PR | n/a This adds an option `--no-prefix` to the `translation:update` command, allowing to use an empty string as prefix. I guess it should be treated as a feature as it adds a new option to the command, but it indeed fixes the bug reported in #20044 (yeah, really this time). Commits ------- b5a1584 [FrameworkBundle] Add --no-prefix option to translation:update
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option
--no-prefixto thetranslation:updatecommand, allowing to use an empty string as prefix. I guess it should be treated as a feature as it adds a new option to the command, but it indeed fixes the bug reported in #20044 (yeah, really this time).