Revert "bug #20184 [FrameworkBundle] Convert null prefix to an empty string in translation:update (chalasr)" #20433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: reviewed |
|
👍 |
|
@javiereguiluz why adding the 3.2 milestone ? This targets the 2.7 branch, as this is where the buggy patch was merged |
|
@stof you are right. The idea of the "3.2" milestone is "PRs to be merged before the release of Symfony 3.2" and not "PRs to be merged exclusively for Symfony 3.2". It'd be sad to release 3.2.0 with well-known bugs that already have a solution and had to wait for 3.2.1. |
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Nov 7, 2016
… to an empty string in translation:update (chalasr)" (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- Revert "bug #20184 [FrameworkBundle] Convert null prefix to an empty string in translation:update (chalasr)" | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20184 (comment) | License | MIT | Doc PR | n/a This reverts commit 3f650f8 because the fix is not valid. It is actually not possible to have an option with value optional given empty to be `empty` if this one has a default value. The default value will always be the one returned, see #20184 (comment) for details. Commits ------- b2fa7c4 Revert "bug #20184 [FrameworkBundle] Convert null prefix to an empty string in translation:update (chalasr)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3f650f8 because the fix is not valid.
It is actually not possible to have an option with value optional given empty to be
emptyif this one has a default value. The default value will always be the one returned, see #20184 (comment) for details.