Skip to content

[Workflow] Removed definition builder #20478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Workflow] Removed definition builder #20478

wants to merge 2 commits into from

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Nov 10, 2016 •
edited
Loading

Q A
Branch? "master"
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

As of @xabbuh comment in #20451 (comment)

We do not really need the definition builder here.

@javiereguiluz javiereguiluz added this to the 3.2 milestone Nov 10, 2016
@stof
Copy link
Member

stof commented Nov 10, 2016

👍
Status: reviewed

@xabbuh
Copy link
Member

xabbuh commented Nov 10, 2016

👍

@lyrixx lyrixx changed the title Removed definition builder [Workflow] Removed definition builder Nov 10, 2016
@lyrixx
Copy link
Member

lyrixx commented Nov 10, 2016

Good catch, thanks Tobias.

@lyrixx lyrixx closed this in e269ca5 Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed Workflow
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@Nyholm @stof @xabbuh @lyrixx @javiereguiluz @carsonbot