Skip to content

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Nov 10, 2016

Q A
Branch? "master"
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

I've checked our major banks websites and we have no better word for "Business Identifier Code" than "BIC". Some banks used "BIC-code" so that is what I wrote here.

@@ -310,6 +310,10 @@
<source>This value does not match the expected {{ charset }} charset.</source>
<target>Detta värde har inte den förväntade teckenkodningen {{ charset }}.</target>
</trans-unit>
<trans-unit id="81">
<source>This is not a valid Business Identifier Code (BIC).</source>
<target>Detta är inte en giltlig BIC-kod.</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google Translate says that giltlig should be giltig Is this a false positive?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow.. you made me unsure so I googled. Found my word on wikipedia "Lists of common misspellings"..

I've updated. Thank you.

@javiereguiluz
Copy link
Member

👍

Wikipedia Swedish page also uses BIC-kod

@magnusnordlander
Copy link
Contributor

I (as a native speaker) can confirm that this translation is correct.

@fabpot
Copy link
Member

fabpot commented Nov 10, 2016

Thank you @Nyholm.

fabpot added a commit that referenced this pull request Nov 10, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20481).

Discussion
----------

[Validator] Added missing swedish translation

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

I've checked our major banks websites and we have no better word for "Business Identifier Code" than "BIC". Some banks used "BIC-code" so that is what I wrote here.

Commits
-------

f3fede2 [Validator] Added missing swedish translation
@fabpot fabpot closed this Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants