Skip to content

[HttpFoundation] Use @final annotation #20495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GuilhemN
Copy link
Contributor

Q A
Branch? "master"
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

As pointed by @theofidry, we can use the @final annotation for classes/methods that we want to make final but we can't before 4.0 because of bc.
This annotation could be used by IDEs and static code analysers to report that it is no longer possible to extend a class/method without breaking code.

@theofidry
Copy link
Contributor

👍 the question being if we want to make use of this tag (I'm all for it), in which requesting IDE support for it there is an issue for phpStorm already would be great.

It is certain that this tag won't be very effective without any tooling around it, but as for @internal, @private IDE integration can come after if the usage is popular and other tools like deptrac for @deprecated can emerge for providing better tooling.

@nicolas-grekas nicolas-grekas added this to the 3.x milestone Dec 6, 2016
@GuilhemN
Copy link
Contributor Author

@GuilhemN GuilhemN closed this Feb 10, 2017
@nicolas-grekas nicolas-grekas modified the milestones: 3.x, 3.3 Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants