[Doctrine][Form] support large integers #20499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 12, 2016
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15642 |
| License | MIT |
| Doc PR | n/a |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 22, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [Doctrine][Form] support large integers | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15642 | License | MIT | Doc PR | n/a Commits ------- 6954a07 [Doctrine][Form] support large integers
apfelbox
reviewed
Nov 22, 2016
| @@ -104,7 +104,7 @@ public function getEntitiesByIds($identifier, array $values) | |||
| // Filter out non-integer values (e.g. ""). If we don't, some | |||
| // databases such as PostgreSQL fail. | |||
| $values = array_values(array_filter($values, function ($v) { | |||
| return (string) $v === (string) (int) $v; | |||
| return (string) $v === (string) (int) $v || ctype_digit($v); | |||
There was a problem hiding this comment.
Why aren't you only using ctype_digit()? Does the first test anything, that the second test does not?
There was a problem hiding this comment.
Yes, ctype_digit() does not work with integers: https://3v4l.org/oi7fd
There was a problem hiding this comment.
Yes, you are right. Maybe is_int($v) || ctype_digit($v) or ctype_digit((string) $v) would be more readable.
Not important, though.
Merged
This was referenced Dec 13, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.