[Serializer][XmlEncoder] Allow removing empty tags in generated XML #20524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Nov 15, 2016
| @@ -393,7 +393,9 @@ private function buildXml(\DOMNode $parentNode, $data, $xmlRootNodeName = null) | |||
| } elseif (is_numeric($key) || !$this->isElementNameValid($key)) { | |||
| $append = $this->appendNode($parentNode, $data, 'item', $key); | |||
| } else { | |||
| $append = $this->appendNode($parentNode, $data, $key); | |||
| if ($data !== null || !isset($this->context['remove_empty_tags']) || $this->context['remove_empty_tags'] === false) { | |||
There was a problem hiding this comment.
and please also use a Yoda condition here: null !== $data
There was a problem hiding this comment.
It's done :
} elseif (null !== $data || !isset($this->context['remove_empty_tags']) || false === $this->context['remove_empty_tags']) {
$append = $this->appendNode($parentNode, $data, $key);
}Use Yoda conditions
xabbuh
approved these changes
Nov 15, 2016
dunglas
reviewed
Nov 15, 2016
| $expected = '<?xml version="1.0"?>'."\n". | ||
| '<response><person><firstname>Peter</firstname></person></response>'."\n"; | ||
|
|
||
| $context = array( |
There was a problem hiding this comment.
You're right i have made the modification
|
👍 |
|
Can you open a doc PR please @amoiraud |
|
Thank you @amoiraud. |
dunglas
added a commit
that referenced
this pull request
Dec 6, 2016
…generated XML (amoiraud) This PR was squashed before being merged into the 3.3-dev branch (closes #20524). Discussion ---------- [Serializer][XmlEncoder] Allow removing empty tags in generated XML | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20398 | License | MIT | Doc PR | ~ Allow a new option in $context of XmlEncoder.php to remove empty tags if $context['remove_empty_tags'] setted to true, changing this : ```xml <node> <subnode>Value</subnode> <emptysubnode/> </node> ``` To this : ```xml <node> <subnode>Value</subnode> </node> ``` Commits ------- 0cb4d8e [Serializer][XmlEncoder] Allow removing empty tags in generated XML
|
Hi @dunglas |
|
@amoiraud, I suggest to add a new section about the |
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 5, 2018
… javiereguiluz) This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #7231). Discussion ---------- Add documentation for XmlEncoder context param Add documentation for XmlEncoder context param Related to : symfony/symfony#20524 This fixes #7227 Commits ------- 5e23045 Minor tweaks adbc7b2 Minor rewords 2dc6ed3 Minor syntax issue 6050370 Minor syntax issues and some rewordings 2f3cf02 Correcting my bad english with a bilingual friend 60c7657 Add XmlEncoder documentation with $context available options 04af434 erratum c83e59d Add XmlEncoder documentation with $context available options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow a new option in $context of XmlEncoder.php to remove empty tags if $context['remove_empty_tags'] setted to true, changing this :
To this :