[Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize #20530
Conversation
|
👍 to remove it as done by this PR. |
|
I would vote for deprecating the method to prevent unexpected BC breaks for users of this class. |
|
@xabbuh Is it really worth it? |
|
Judging by the name of the method and given the fact that people will use the |
|
Ok, fair enough. Let's add a deprecation notice then. |
|
After a quick search, I wasn't able to find any public project using this method. Regarding the fact that it was introduced in 3.1 (only 6 months ago) and is useless, I really doubt than anybody has used it. |
|
Maybe add a Imo. we can totally be pragmatic on left-over code from one minor to another. But it should be documented. |
|
👍 on my side for an UPGRADE entry and no deprecation. |
381b731 to
63e94b4
Compare
|
Thank you @dunglas. |
…oNormalize (dunglas) This PR was squashed before being merged into the 3.1 branch (closes #20530). Discussion ---------- [Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | unclear | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a I've introduced this method by error in #17113. It has been forgotten during a refactoring. It has always been unused, is not covered by our test suite and has never been documented. Technically it's a BC break (because this is a protected method), but I think that it's better to remove it has it has never be intended to be used, it's just a miss. An alternative is to deprecate it and remove it in v4. Commits ------- fea18aa [Serializer] Remove AbstractObjectNormalizer::isAttributeToNormalize
I've introduced this method by error in #17113. It has been forgotten during a refactoring. It has always been unused, is not covered by our test suite and has never been documented.
Technically it's a BC break (because this is a protected method), but I think that it's better to remove it has it has never be intended to be used, it's just a miss. An alternative is to deprecate it and remove it in v4.