Skip to content

[ci] Testing with UTC hides bugs #20551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ before_install:
# A sigchild-enabled-PHP is used to test the Process component on the lowest PHP matrix line
- if [[ ! $deps && $PHP = ${MIN_PHP%.*} && ! -d php-$MIN_PHP/sapi ]]; then wget http://museum.php.net/php5/php-$MIN_PHP.tar.bz2 -O - | tar -xj; (cd php-$MIN_PHP; ./configure --enable-sigchild --enable-pcntl; make -j2); fi
- if [[ ! $PHP = hhvm* ]]; then INI_FILE=~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/travis.ini; else INI_FILE=/etc/hhvm/php.ini; fi
- if [[ ! $skip ]]; then echo date.timezone = Europe/Paris >> $INI_FILE; fi
- if [[ ! $skip ]]; then echo memory_limit = -1 >> $INI_FILE; fi
- if [[ ! $skip ]]; then echo session.gc_probability = 0 >> $INI_FILE; fi
- if [[ ! $skip && $PHP = 5.* ]]; then echo extension = mongo.so >> $INI_FILE; fi
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ install:
- cd ..
- copy /Y php.ini-development php.ini-min
- echo max_execution_time=1200 >> php.ini-min
- echo date.timezone="UTC" >> php.ini-min
- echo date.timezone="America/Los_Angeles" >> php.ini-min
- echo extension_dir=ext >> php.ini-min
- copy /Y php.ini-min php.ini-max
- echo extension=php_openssl.dll >> php.ini-max
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function testTransformWithRounding($input, $output, $roundingMode)
public function testReverseTransform()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -109,7 +109,7 @@ public function testReverseTransformEmpty()
public function testReverseTransformWithGrouping()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class MoneyToLocalizedStringTransformerTest extends \PHPUnit_Framework_TestCase
public function testTransform()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -47,7 +47,7 @@ public function testTransformEmpty()
public function testReverseTransform()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public function provideTransformations()
public function testTransform($from, $to, $locale)
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault($locale);

Expand All @@ -68,7 +68,7 @@ public function provideTransformationsWithGrouping()
public function testTransformWithGrouping($from, $to, $locale)
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault($locale);

Expand All @@ -80,7 +80,7 @@ public function testTransformWithGrouping($from, $to, $locale)
public function testTransformWithScale()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -185,7 +185,7 @@ public function transformWithRoundingProvider()
public function testTransformWithRounding($scale, $input, $output, $roundingMode)
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -197,7 +197,7 @@ public function testTransformWithRounding($scale, $input, $output, $roundingMode
public function testTransformDoesNotRoundIfNoScale()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -212,7 +212,7 @@ public function testTransformDoesNotRoundIfNoScale()
public function testReverseTransform($to, $from, $locale)
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault($locale);

Expand All @@ -227,7 +227,7 @@ public function testReverseTransform($to, $from, $locale)
public function testReverseTransformWithGrouping($to, $from, $locale)
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault($locale);

Expand All @@ -244,7 +244,7 @@ public function testReverseTransformWithGrouping($to, $from, $locale)
public function testReverseTransformWithGroupingAndFixedSpaces()
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('ru');

Expand All @@ -256,7 +256,7 @@ public function testReverseTransformWithGroupingAndFixedSpaces()
public function testReverseTransformWithGroupingButWithoutGroupSeparator()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -376,7 +376,7 @@ public function testReverseTransformDoesNotRoundIfNoScale()
public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('fr');
$transformer = new NumberToLocalizedStringTransformer(null, true);
Expand All @@ -396,7 +396,7 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsNotDot()
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -411,7 +411,7 @@ public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot()
public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDotWithNoGroupSep()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -423,7 +423,7 @@ public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDotWithNoGro
public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsDotButNoGroupingUsed()
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('fr');
$transformer = new NumberToLocalizedStringTransformer();
Expand All @@ -435,7 +435,7 @@ public function testDecimalSeparatorMayBeDotIfGroupingSeparatorIsDotButNoGroupin
public function testDecimalSeparatorMayBeCommaIfGroupingSeparatorIsNotComma()
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('bg');
$transformer = new NumberToLocalizedStringTransformer(null, true);
Expand Down Expand Up @@ -588,7 +588,7 @@ public function testReverseTransformDisallowsCenteredExtraCharacters()
public function testReverseTransformDisallowsCenteredExtraCharactersMultibyte()
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('ru');

Expand All @@ -605,7 +605,7 @@ public function testReverseTransformDisallowsCenteredExtraCharactersMultibyte()
public function testReverseTransformIgnoresTrailingSpacesInExceptionMessage()
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('ru');

Expand Down Expand Up @@ -633,7 +633,7 @@ public function testReverseTransformDisallowsTrailingExtraCharacters()
public function testReverseTransformDisallowsTrailingExtraCharactersMultibyte()
{
// Since we test against other locales, we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('ru');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function testTransformWithInteger()
public function testTransformWithScale()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -92,7 +92,7 @@ public function testReverseTransformWithInteger()
public function testReverseTransformWithScale()
{
// Since we test against "de_AT", we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class CountryTypeTest extends TestCase
{
protected function setUp()
{
IntlTestHelper::requireIntl($this);
IntlTestHelper::requireIntl($this, false);

parent::setUp();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class CurrencyTypeTest extends TestCase
{
protected function setUp()
{
IntlTestHelper::requireIntl($this);
IntlTestHelper::requireIntl($this, false);

parent::setUp();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public function testSubmitFromSingleTextDateTimeWithDefaultFormat()
public function testSubmitFromSingleTextDateTime()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -91,7 +91,7 @@ public function testSubmitFromSingleTextDateTime()
public function testSubmitFromSingleTextString()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -112,7 +112,7 @@ public function testSubmitFromSingleTextString()
public function testSubmitFromSingleTextTimestamp()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -135,7 +135,7 @@ public function testSubmitFromSingleTextTimestamp()
public function testSubmitFromSingleTextRaw()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -399,7 +399,7 @@ public function testThrowExceptionIfDaysIsInvalid()
public function testSetDataWithNegativeTimezoneOffsetStringInput()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -421,7 +421,7 @@ public function testSetDataWithNegativeTimezoneOffsetStringInput()
public function testSetDataWithNegativeTimezoneOffsetDateTimeInput()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -495,7 +495,7 @@ public function testMonthsOptionShortFormat()
public function testMonthsOptionLongFormat()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -515,7 +515,7 @@ public function testMonthsOptionLongFormat()
public function testMonthsOptionLongFormatWithDifferentTimezone()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -621,7 +621,7 @@ public function testIsPartiallyFilledReturnsTrueIfChoiceAndDayEmpty()
public function testPassDatePatternToView()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand All @@ -634,7 +634,7 @@ public function testPassDatePatternToView()
public function testPassDatePatternToViewDifferentFormat()
{
// we test against "de_AT", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_AT');

Expand Down Expand Up @@ -682,7 +682,7 @@ public function testDontPassDatePatternIfText()
public function testDatePatternFormatWithQuotedStrings()
{
// we test against "es_ES", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('es_ES');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class IntegerTypeTest extends TestCase
{
protected function setUp()
{
IntlTestHelper::requireIntl($this);
IntlTestHelper::requireIntl($this, false);

parent::setUp();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class LanguageTypeTest extends TestCase
{
protected function setUp()
{
IntlTestHelper::requireIntl($this);
IntlTestHelper::requireIntl($this, false);

parent::setUp();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class LocaleTypeTest extends TestCase
{
protected function setUp()
{
IntlTestHelper::requireIntl($this);
IntlTestHelper::requireIntl($this, false);

parent::setUp();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ protected function setUp()
{
// we test against different locales, so we need the full
// implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

parent::setUp();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ protected function setUp()
parent::setUp();

// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

\Locale::setDefault('de_DE');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class CollatorTest extends AbstractCollatorTest
{
protected function setUp()
{
IntlTestHelper::requireFullIntl($this);
IntlTestHelper::requireFullIntl($this, false);

parent::setUp();
}
Expand Down
Loading