Skip to content

Fix annotation type for $context #20561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2016
Merged

Fix annotation type for $context #20561

merged 1 commit into from
Nov 22, 2016

Conversation

KmeCnin
Copy link
Contributor

@KmeCnin KmeCnin commented Nov 18, 2016

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Previous type ExecutionContextInterface was referring to a non declared namespace. Replacing it by ExecutionContextInterface2Dot5 fixes autocomplete.

@KmeCnin
Fix annotation type for $context
55e134c 
Previous type ExecutionContextInterface was referring to a non declared namespace. Replacing it by ExecutionContextInterface2Dot5 fixes autocomplete.
@fabpot
Copy link
Member

fabpot commented Nov 22, 2016

Good catch, thanks @KmeCnin.

@fabpot fabpot merged commit 55e134c into symfony:2.8 Nov 22, 2016
fabpot added a commit that referenced this pull request Nov 22, 2016
@fabpot
minor #20561 Fix annotation type for $context (KmeCnin)
adaa8ec 
This PR was merged into the 2.8 branch.

Discussion
----------

Fix annotation type for $context

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Previous type ExecutionContextInterface was referring to a non declared namespace. Replacing it by ExecutionContextInterface2Dot5 fixes autocomplete.

Commits
-------

55e134c Fix annotation type for $context
@HeahDude
Copy link
Contributor

HeahDude commented Dec 7, 2016

@mcfedr which version of symfony?

@xabbuh
Copy link
Member

xabbuh commented Dec 7, 2016

@mcfedr see #20766 which will be part of the next patch release

@KmeCnin
Copy link
Contributor Author

KmeCnin commented Dec 7, 2016 •
edited
Loading

@mcfedr this fix concerns only the branch 2.8. In upper versions, ExecutionContextInterface2Dot5 does not exists anymore. It's only an alias used for backward-compatibility in 2.8.

@KmeCnin KmeCnin deleted the patch-1 branch December 7, 2016 13:54
@mcfedr
Copy link
Contributor

mcfedr commented Dec 7, 2016

I am using 3.2 - looks like this patch should have just landed in 2.X branch.

@KmeCnin
Copy link
Contributor Author

KmeCnin commented Dec 7, 2016 •
edited
Loading

@mcfedr

fabpot merged commit 55e134c into symfony:2.8 16 days ago

So I don,'t know how it landed in your branch.

@xabbuh
Copy link
Member

xabbuh commented Dec 7, 2016

@KmeCnin @mcfedr We regularly merge lower branches up to master. That's how this commit landed in 3.1, but this has already been fixed by #20766.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@KmeCnin @fabpot @HeahDude @xabbuh @mcfedr @stof @Ma27 @carsonbot