[Console] Ease writing to stderr using SymfonyStyle #20586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Nov 21, 2016
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15986 |
| License | MIT |
| Doc PR | n/a |
3aebb3a to
e8f2aa4
Compare
|
Can't be in 2.8, should be in master |
e8f2aa4 to
dadbebe
Compare
a57543c to
2848adc
Compare
|
Changed the scope then, proposing |
|
@chalasr you decide :) |
|
Even adding a new method must be in master, as it is a new feature |
stof
requested changes
Nov 25, 2016
| return; | ||
| $this->listBundles($errorIo); | ||
| $errorIo->comment('Provide the name of a bundle as the first argument of this command to dump its configuration. (e.g. <comment>debug:config FrameworkBundle</comment>)'); | ||
| $errorIo->comment('For dumping a specific option, add its path as the second argument of this command. (e.g. <comment>debug:config FrameworkBundle serializer</comment> to dump the <comment>framework.serializer</comment> configuration)'); |
There was a problem hiding this comment.
Could you please dismiss your review? As the change is no more in this PR
2848adc to
b2d7a1a
Compare
ogizanagi
reviewed
Nov 25, 2016
|
|
||
| public function testGetErrorIo() | ||
| { | ||
| $input = $this->getMock('Symfony\Component\Console\Input\InputInterface'); |
There was a problem hiding this comment.
Could use the InputInterface::class notation now that this PR targets master
b2d7a1a to
293e627
Compare
fabpot
reviewed
Dec 13, 2016
| * | ||
| * @return self | ||
| */ | ||
| public function getErrorIo() |
There was a problem hiding this comment.
The method name looks weird to me as we don't use IO anywhere in the code IIRC
There was a problem hiding this comment.
I agree. getErrorStyle() ?
There was a problem hiding this comment.
Changed to getErrorStyle()
1adbc3e to
ed656e2
Compare
| protected function getErrorOutput() | ||
| { | ||
| if (!$this->output instanceof ConsoleOutputInterface) { | ||
| return; |
3a02b96 to
43b7085
Compare
fabpot
reviewed
Jan 6, 2017
| protected function getErrorOutput() | ||
| { | ||
| if (!$this->output instanceof ConsoleOutputInterface) { | ||
| throw new LogicException(sprintf('The output must be an instance of %s for using getErrorOutput().', ConsoleOutputInterface::class)); |
There was a problem hiding this comment.
What about returning the regular output instead?
552c419 to
207836f
Compare
207836f to
5b0504c
Compare
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Jan 6, 2017
…halasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [Console] Ease writing to stderr using SymfonyStyle | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15986 | License | MIT | Doc PR | n/a Commits ------- 5b0504c [Console] Ease writing to stderr using styles
fabpot
added a commit
that referenced
this pull request
Feb 19, 2017
…output (chalasr, ogizanagi) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Make use of stderr for non reliable output | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Built-in commands should make use of the proper outputs. As a feature on master, considering that people may actually rely on stdout and the fact commands have been changed a lot since 2.7, I think it's not worth doing this change on lower branches. Please see also #20586 which adds a `SymfonyStyle::getErrorStyle()` shortcut for easily switching to stderr. Commits ------- 7b262d8 [FrameworkBundle] Use getErrorStyle() when relevant 9a3a568 Use stderr for some other commands 1ee48bf [FrameworkBundle] Make use of stderr for non reliable output
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 28, 2017
…ing SymfonyStyle (chalasr, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Console] Document how to exclude messages from output using SymfonyStyle This adds documentation for symfony/symfony#20586, any suggestion will be really welcomed. Commits ------- a5c5524 Minor fix ff0ccde Reworded the description 31a2a44 Document how to exclude irrelevant messages from command output using SymfonyStyle
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.