[DI] Allow null as default env value #20590
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68e4929 to
ec71fb8
Compare
| public function testGetEndAllowsNull() | ||
| { | ||
| $bag = new EnvPlaceholderParameterBag(); | ||
| $bag->set('env(ARRAY_VAR)', null); |
There was a problem hiding this comment.
can you call this one NULL_VAR?
| { | ||
| $bag = new EnvPlaceholderParameterBag(); | ||
| $bag->set('env(ARRAY_VAR)', null); | ||
| $bag->get('env(ARRAY_VAR)'); |
There was a problem hiding this comment.
this test case is missing an assertion
|
👍 |
ec71fb8 to
92b7ec9
Compare
92b7ec9 to
28ff2b8
Compare
|
👍 |
ro0NL
reviewed
Nov 22, 2016
| @@ -139,4 +139,26 @@ public function testResolveThrowsOnBadDefaultValue() | |||
| $bag->set('env(Array_Var)', array()); | |||
| $bag->resolve(); | |||
| } | |||
|
|
|||
| public function testGetEndAllowsNull() | |||
There was a problem hiding this comment.
This should be GetEnv right?
| if (!is_scalar($defaultValue)) { | ||
| throw new RuntimeException(sprintf('The default value of an env() parameter must be scalar, but "%s" given to "%s".', gettype($defaultValue), $name)); | ||
| if (null !== $defaultValue && !is_scalar($defaultValue)) { | ||
| throw new RuntimeException(sprintf('The default value of an env() parameter must be scalar or null, but "%s" given to "%s".', gettype($defaultValue), $name)); |
There was a problem hiding this comment.
Meanwhile, can you please update the below message on line 100, to say "scalar or null" there also instead of "string or null"? (you should have a test to tweak also).
|
Good catch, thanks @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 23, 2016
This PR was squashed before being merged into the 3.2 branch (closes #20590). Discussion ---------- [DI] Allow null as default env value | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø This PR allows the environment variable default value to be null. The way, we can allow optional environment variables, such as in this example: ```yaml parameters: # Default values env(DATABASE_HOST): database env(DATABASE_PORT): ~ env(DATABASE_NAME): symfony env(DATABASE_USERNAME): root env(DATABASE_PASSWORD): ~ # Database configuration database_host: "%env(DATABASE_HOST)%" database_port: "%env(DATABASE_PORT)%" database_name: "%env(DATABASE_NAME)%" database_user: "%env(DATABASE_USERNAME)%" database_password: "%env(DATABASE_PASSWORD)%" ``` Commits ------- 519a471 [DI] Allow null as default env value
Merged
OskarStark
added a commit
that referenced
this pull request
Feb 28, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Notifier][Webhook] Add Smsbox support | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT |Doc | [#20590](symfony/symfony-docs#20590) Add support for Webhook to Smsbox Notifier Event statuses come from Smsbox [documentation](https://en.smsbox.net/docs/doc-APIReceive-SMSBOX-EN.pdf). Commits ------- 08062e8 [Notifier][Webhook] Add Smsbox support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the environment variable default value to be null. The way, we can allow optional environment variables, such as in this example: