[WebProfilerBundle] Display multiple HTTP headers in WDT #20599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I moved the logic in the request collector: https://github.com/symfony/symfony/pull/20595/files#diff-e8f5b14fbfbbeac60fc9f3abe310c3b0R128 |
|
Updated, rebasing should be easy now. |
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Dec 19, 2016
…ro0NL) This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Display multiple HTTP headers in WDT | Q | A | ------------- | --- | Branch? | 2.7 (partially in 3.2 already) | Bug fix? | yes | New feature? | no | BC breaks? | no-ish | Deprecations? | no | Tests pass? | yes | Fixed tickets | [#20595 (comment)](#20595 (comment)) | License | MIT | Doc PR | reference to the documentation PR, if any Backport of #20595 for 2.7, that includes a fix for displaying multiple HTTP headers in the WDT.  //cc @nicolas-grekas this should cover 2.7 - 3.1 right? Commits ------- 257a856 [WebProfilerBundle] Display multiple HTTP headers in WDT
ro0NL
commented
Dec 19, 2016
| } | ||
| if (count($cookies) > 0) { | ||
| $responseHeaders['Set-Cookie'] = $cookies; | ||
| $responseHeaders['set-cookie'][] = (string) $cookie; | ||
| } |
| $this->data[$key] = $value; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Above should apply to 3.1 as well.
In master this is already applied due #20595.
| @@ -183,7 +189,7 @@ public function getRequestQuery() | |||
|
|
|||
| public function getRequestHeaders() | |||
| { | |||
| return new HeaderBag($this->data['request_headers']); | |||
| return new ParameterBag($this->data['request_headers']); | |||
There was a problem hiding this comment.
Same, should be applied to 3.1
| @@ -203,7 +209,7 @@ public function getRequestAttributes() | |||
|
|
|||
| public function getResponseHeaders() | |||
| { | |||
| return new ResponseHeaderBag($this->data['response_headers']); | |||
| return new ParameterBag($this->data['response_headers']); | |||
There was a problem hiding this comment.
Same, should be applied to 3.1
| } | ||
|
|
||
| return $cookie; | ||
| } |
There was a problem hiding this comment.
Same, should be applied to 3.1
and the remaining tests of course.
This was referenced Dec 20, 2016
fabpot
added a commit
that referenced
this pull request
Dec 22, 2016
This PR was merged into the 3.1 branch. Discussion ---------- [HttpKernel] Continuation of #20599 for 3.1 | Q | A | ------------- | --- | Branch? | 3.1 only | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> #20599 is only merged up to 2.8.. not sure if 3.1 is already EOM? Commits ------- c245f87 [HttpKernel] Continuation of #20599 for 3.1
fabpot
added a commit
that referenced
this pull request
Dec 22, 2016
* 3.1: [HttpKernel] Continuation of #20599 for 3.1
fabpot
added a commit
that referenced
this pull request
Dec 22, 2016
* 3.2: [HttpKernel] Continuation of #20599 for 3.1 Add missing upgrade path for Request::isMethodSafe() deprecation
This was referenced Jan 12, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20595 for 2.7, that includes a fix for displaying multiple HTTP headers in the WDT.
//cc @nicolas-grekas this should cover 2.7 - 3.1 right?