[Validator] Bring egulias/email-validator ~2.0 to parity with ~1.2 #20607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @xabbuh as you were the one who implemented it. WDYT ? |
|
👍 Status: Reviewed |
|
Thank you @Lctrs. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2016
…ith ~1.2 (Lctrs) This PR was merged into the 3.2 branch. Discussion ---------- [Validator] Bring egulias/email-validator ~2.0 to parity with ~1.2 | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | could be ? | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | When using egulias/email-validator ~1.2, we make a strict check of the email, which means that emails with RFC warnings will fail validation. Currently with egulias/email-validator ~2.0, emails with warnings are considerate valids. This pull request make EmailValidator with egulias/email-validator ~2.0 behave as with egulias/email-validator ~1.2. Commits ------- 01b2f66 Switch to NoRFCWarningsValidation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using egulias/email-validator ~1.2, we make a strict check of the email, which means that emails with RFC warnings will fail validation.
Currently with egulias/email-validator ~2.0, emails with warnings are considerate valids.
This pull request make EmailValidator with egulias/email-validator ~2.0 behave as with egulias/email-validator ~1.2.