[FrameworkBundle] Add framework.cache.prefix_seed for predictible cache key prefixes #20610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Nov 23, 2016
| @@ -1242,6 +1242,9 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con | |||
| $container->getDefinition('cache.adapter.system')->replaceArgument(2, $version); | |||
| $container->getDefinition('cache.adapter.filesystem')->replaceArgument(2, $config['directory']); | |||
|
|
|||
| if (isset($config['prefix_seed'])) { | |||
| $container->setParameter('cache.prefix.seed', $config['prefix_seed']); | |||
There was a problem hiding this comment.
Why not setting it directly on the pass it self? Yes; foreaching all passes to find any instance of CachePoolPass.
Otherwise maybe use a less generic name, to clarify something's going on (it's a tmp thingy, only to transfer config..), ie. setParameter(CachePoolPass::class.'_prefix_seed').
There was a problem hiding this comment.
To achieve which goal?
There was a problem hiding this comment.
Guess to avoid creating params into the wild and making things less implicit. Im fine with it though.. just curious :)
This mix&matches framework.cache.prefix_seed and %cache.prefix.seed%, they're the same. In apps this often shows a code smell, as people tend to use params as some global config array, by exactly doing this.
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2016
…ictible cache key prefixes (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Add framework.cache.prefix_seed for predictible cache key prefixes | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - That's a design issue: using root_dir as discriminant doesn't work with blue/green deployment strategies, and doesn't prevent collision when different apps are deployed in the same path while sharing the same cache backend. Commits ------- 82952bd [FrameworkBundle] Add framework.cache.prefix_seed for predictible cache key prefixes
nicolas-grekas
added a commit
that referenced
this pull request
Nov 25, 2016
…rating cache namespace (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [Bridge/Doctrine] Use cache.prefix.seed parameter for generating cache namespace | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Exactly the same issue as in #20610, but for Doctrine ORM's cache: > That's a design issue: using root_dir as discriminant doesn't work with blue/green deployment strategies, and doesn't prevent collision when different apps are deployed in the same path while sharing the same cache backend. Commits ------- 5e3cbec [Bridge/Doctrine] Use cache.prefix.seed parameter for generating cache namespace
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a design issue: using root_dir as discriminant doesn't work with blue/green deployment strategies, and doesn't prevent collision when different apps are deployed in the same path while sharing the same cache backend.