I would make these the final returns, ie. return 'ini' === $type;

Indeed it's better 👍 Thanks.

return 'ini' === $type; should be enough

Oops. Forgot to update after #20611 (comment)... Thanks.

Shouldn't we check type first? If I set this option explicitly, I expect it to have top priority:

public function supports($resource, $type = null)
{
    if (!is_string($resource)) {
        return false;
    }

    return 'ini' === $type || 'ini' === pathinfo($resource, PATHINFO_EXTENSION);
}

@javiereguiluz the extension is checked only when the type is null. So there is no question of priority

the type will have priority if explicitly provided with current implementation, as the above condition has a null === $type check.

The difference with your snippet is that the loader won't return true in case the type was explicitly provided, but not ini and the extension is ini (another loader should try)

the loader won't return true in case the type was explicitly provided, but not ini and the extension is ini (another loader should try)

@ogizanagi in that case, this code will be: ...
Maybe I'm missing something here.

updated: I see my mistake now. Thanks!

@stof maybe "priority" is not the best word, but the new behavior is: "do whatever "type" tells you ... if it doesn't tell you anything, fall back to the file extension".

What I meant is calling:

1. supports('services.ini, 'ini') should return true
2. supports('services.foo, 'ini') should return true
3. supports('services.ini, 'yaml') should return false

The third case will be erroneous with your suggestion.

null !== $type should be removed in all loaders. It is useless as the condition 'php' === $type already ensures is is not null

Don't know what happened here, I'm pretty sure I fixed this a long time ago... Thanks.