Fix legacy tests that do not trigger any depreciation #20638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we rather initialise the property with the empty array then instead of using |
|
It may be clearer indeed to initialize both expectedDeprecations and gatheredDeprecations to the empty array, and reset them also L184. Can you take care of that @julienfalque please? |
c951e72 to
9287b52
Compare
|
Done |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @julienfalque. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 26, 2016
…ienfalque) This PR was merged into the 3.2 branch. Discussion ---------- Fix legacy tests that do not trigger any depreciation | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes `implode(): Invalid arguments passed` error when a `@legacy` test with `@expectedDeprecation` does not actually trigger any deprecation. Commits ------- 9287b52 Fix tests that do not trigger any depreciation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
implode(): Invalid arguments passederror when a@legacytest with@expectedDeprecationdoes not actually trigger any deprecation.