[FrameworkBundle] Add project directory default for installing assets #20642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering assets are static, the recommendation is to put them in the web-dir: http://symfony.com/doc/current/best_practices/web-assets.html Edit; As this is a new feature, it should be aimed at the master |
|
@noahheck can you please rebase on master + change base branch on github? |
37cf20b to
7a11f3e
Compare
|
Thank you @noahheck. |
fabpot
added a commit
that referenced
this pull request
Mar 22, 2017
…stalling assets (Noah Heck) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Add project directory default for installing assets | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20337 | License | MIT | Doc PR | This allows the `assets:install` console command to have a fallback default of the project root directory. Current behavior is to install assets only in the `target` of the current working directory. Commits ------- 7a11f3e [FrameworkBundle] Add project directory default for installing assets
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
assets:installconsole command to have a fallback default of the project root directory.Current behavior is to install assets only in the
targetof the current working directory.