Maintain the selected panel when redirecting to another profile #20646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Nov 26, 2016
| Q | A |
|---|---|
| Branch? | 3.1 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #20637 |
| License | MIT |
| Doc PR | - |
ro0NL
reviewed
Nov 26, 2016
| @@ -39,7 +39,7 @@ | |||
| {%- else -%} | |||
| {{ redirect_route }} | |||
| {%- endif %} | |||
| (<a href="{{ path('_profiler', { token: redirect.token }) }}">{{ redirect.token }}</a>) | |||
| (<a href="{{ path('_profiler', { token: redirect.token, panel: app.request.query.get('panel', 'request') }) }}">{{ redirect.token }}</a>) | |||
There was a problem hiding this comment.
Not sure it should hardcode the default panel name (request). It's not needed right?
There was a problem hiding this comment.
In case it's null I'd prefer to set the default panel name instead of relying of auto-redirection to some panel. But your proposal is correct too. They are just different opinions on the same subject!
There was a problem hiding this comment.
@javiereguiluz please use request, not app.request. The WebProfilerBundle does not depend on the app global variable before your change, making it compatible with Silex (where the app global variable is the Silex application itself, and so no compatible with app.request)
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Dec 6, 2016
…ofile (javiereguiluz) This PR was merged into the 3.1 branch. Discussion ---------- Maintain the selected panel when redirecting to another profile | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20637 | License | MIT | Doc PR | - Commits ------- de7b326 Maintain the selected panel when redirecting to another profile
javiereguiluz
added a commit
that referenced
this pull request
Dec 6, 2016
…iereguiluz) This PR was merged into the 3.1 branch. Discussion ---------- Don't use the "app" global variable in the profiler | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The use of the `app` variable makes this incompatible with projects like Silex (as pointed by @stof in #20646 (comment)) Commits ------- a777618 Don't use the "app" global variable in the profiler
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…ther profile (javiereguiluz) This PR was merged into the 3.1 branch. Discussion ---------- Maintain the selected panel when redirecting to another profile | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20637 | License | MIT | Doc PR | - Commits ------- de7b326 Maintain the selected panel when redirecting to another profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.