[DependencyInjection] Added a shortcut method for autowired definitions #20648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuilhemN
reviewed
Nov 26, 2016
| */ | ||
| public function autowire($id, $class = null) | ||
| { | ||
| return $this->setDefinition((new Definition($class))->setAutowired(true)); |
There was a problem hiding this comment.
Thanks, updated it and added a simple test.
|
We should plan for #20167 also |
|
@nicolas-grekas I agree. What about introducing a third (optional) type parameter? |
|
I like the shortcut but the name made me think the method allows to autowire an existing service more than registering a new autowired one (i.e replace |
|
|
|
I love it 👍 |
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Dec 13, 2016
…wired definitions (wouterj)
This PR was merged into the 3.3-dev branch.
Discussion
----------
[DependencyInjection] Added a shortcut method for autowired definitions
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | todo
This is a simple proposal to make adding autowired definitions to the `ContainerBuilder` a little easier. Registering autowired services in PHP code was quite verbose at the moment, while the whole point of autowiring is quick service registration.
**Before**
```php
$container->register('app.twig_extension', AppExtension::class)
->setAutowired(true)
->addTag('twig.extension')
;
```
**After**
```php
$container->autowire('app.twig_extension', AppExtension::class)
->addTag('twig.extension')
;
```
With #20264, this will be even nicer:
```php
$container->autowire(AppExtension::class)
->addTag('twig.extension')
;
```
Commits
-------
6ef4ce8 Added a shortcut method for autowired definitions
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple proposal to make adding autowired definitions to the
ContainerBuildera little easier. Registering autowired services in PHP code was quite verbose at the moment, while the whole point of autowiring is quick service registration.Before
After
With #20264, this will be even nicer: