Updated the "PHP config" panel in the profiler #20697
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 30, 2016
| 'xdebug_enabled' => extension_loaded('xdebug'), | ||
| 'eaccel_enabled' => extension_loaded('eaccelerator') && ini_get('eaccelerator.enable'), | ||
| 'apc_enabled' => extension_loaded('apc') && ini_get('apc.enabled'), |
There was a problem hiding this comment.
We could even drop the case of APC here, because APC does not have its opcode caching features anymore on PHP 5.5+ (as it can only be installed thanks to the BC layer of APCu)
There was a problem hiding this comment.
In 5a7f20a I've changed this to only check for APCu. Is that a better idea or should we remove this APC check entirely? Thanks!
There was a problem hiding this comment.
@javiereguiluz I'd prefer to retain APCu check (but not APC-original, as removed in 5a7f20a)
| @@ -67,11 +67,11 @@ public function collect(Request $request, Response $response, \Exception $except | |||
| 'env' => isset($this->kernel) ? $this->kernel->getEnvironment() : 'n/a', | |||
| 'debug' => isset($this->kernel) ? $this->kernel->isDebug() : 'n/a', | |||
| 'php_version' => PHP_VERSION, | |||
| 'php_architecture' => PHP_INT_SIZE * 8, | |||
| 'php_locale' => \Locale::getDefault() ?: 'n/a', | |||
There was a problem hiding this comment.
technically, this is the Intl locale, not the PHP locale (which would be the one set by setlocale
There was a problem hiding this comment.
Thanks for noticing this. What should we do here?
- Relabel this to
Intl locale - Get the PHP locale in a different way
- Remove this for not being reliable
There was a problem hiding this comment.
I would relabel it. The Intl locale is more useful than the PHP locale in Symfony, as our own code does not deal with the PHP locale (it would be useful to display it if you were using ext-gettext to handle translations)
|
Just throwing the idea even if that's not for this PR: would be great to have a panel/section to display APCu & opcache stats, based on apcu_cache/sma_info() & opcache_get_status(). |
|
@nicolas-grekas that a good idea! What if we add those to the upcoming "Cache" panel? |
|
@javiereguiluz do you plan to extract x.y.z from the full PHP version? ie. mine is |
|
👍 |
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Dec 13, 2016
…eguiluz) This PR was squashed before being merged into the 3.3-dev branch (closes #20697). Discussion ---------- Updated the "PHP config" panel in the profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I propose to update this panel taking some of the ideas introduced by @ro0NL in #20126: * Adding more info that helps debugging problems (like 32/64 bits, the locale and the timezone) * Removing anything related to PHP acceleration that is not OPcache or APC ### Before  ### After  Commits ------- 531053b Updated the "PHP config" panel in the profiler
fabpot
added a commit
that referenced
this pull request
Dec 15, 2016
…gizanagi) This PR was merged into the 3.3-dev branch. Discussion ---------- [WebProfilerBundle] Fix PHP extensions in the toolbar | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes (adding other extensions info) | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20697 | License | MIT | Doc PR | N/A `ConfigDataCollector::hasAccelerator()` has been removed. Except if we want to reintroduce the method, I'd suggest to add apcu & opcache infos directly (or just remove the accelerator line). Commits ------- 2495030 [WebProfilerBundle] Fix PHP extensions in the toolbar
fabpot
added a commit
that referenced
this pull request
Dec 19, 2016
This PR was merged into the 3.3-dev branch. Discussion ---------- [WebProfilerBundle] Split PHP version if needed | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #20697 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Commits ------- 1241a00 [WebProfilerBundle] Split PHP version if needed
symfony-splitter
pushed a commit
to symfony/http-kernel
that referenced
this pull request
Dec 19, 2016
This PR was merged into the 3.3-dev branch. Discussion ---------- [WebProfilerBundle] Split PHP version if needed | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | symfony/symfony#20697 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Commits ------- 1241a00 [WebProfilerBundle] Split PHP version if needed
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…(javiereguiluz) This PR was squashed before being merged into the 3.3-dev branch (closes symfony#20697). Discussion ---------- Updated the "PHP config" panel in the profiler | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I propose to update this panel taking some of the ideas introduced by @ro0NL in symfony#20126: * Adding more info that helps debugging problems (like 32/64 bits, the locale and the timezone) * Removing anything related to PHP acceleration that is not OPcache or APC ### Before  ### After  Commits ------- 531053b Updated the "PHP config" panel in the profiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to update this panel taking some of the ideas introduced by @ro0NL in #20126:
Before
After