[WebProfilerBundle] Fix AJAX panel with fetch requests #20724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX: Bug trying to use a Request object as an string, because window.fetch implementation doesn't support Request as param, always is expecting url and params object.
|
@OnekO I rebased your branch to base it on 3.2 rather than master, as you started the edition in master rather than your target branch. |
stof
reviewed
Dec 2, 2016
| @@ -243,6 +243,17 @@ | |||
| var oldFetch = window.fetch; | |||
| window.fetch = function () { | |||
| var promise = oldFetch.apply(this, arguments); | |||
| var paramType = Object.prototype.toString.call(arguments[0]); | |||
| if (paramType === '[object Request]') { | |||
| arguments[0] = arguments[0].url; | |||
There was a problem hiding this comment.
we should not mutate arguments. It can cause issues. We should be using local variables instead
There was a problem hiding this comment.
You are right, I changed it again.
|
Thx :) |
Using local variables instead mutating arguments.
|
Thank you @OnekO. |
fabpot
added a commit
that referenced
this pull request
Dec 13, 2016
…ekO) This PR was squashed before being merged into the 3.2 branch (closes #20724). Discussion ---------- [WebProfilerBundle] Fix AJAX panel with fetch requests | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20723 | License | MIT | Doc PR | None Commits ------- 5527ee3 [WebProfilerBundle] Fix AJAX panel with fetch requests
Merged
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
…sts (OnekO) This PR was squashed before being merged into the 3.2 branch (closes symfony#20724). Discussion ---------- [WebProfilerBundle] Fix AJAX panel with fetch requests | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20723 | License | MIT | Doc PR | None Commits ------- 5527ee3 [WebProfilerBundle] Fix AJAX panel with fetch requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.