Skip to content

Conversation

Babacooll
Copy link

@Babacooll Babacooll commented Dec 3, 2016

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@nicolas-grekas
Copy link
Member

Why don't you use the AbstractAdapter? It should make the implementation a lot lighter, isn't it?

@nicolas-grekas
Copy link
Member

See #20752 for another PR on the same topic.

@nicolas-grekas nicolas-grekas added this to the 3.x milestone Dec 6, 2016
@nicolas-grekas
Copy link
Member

Closing in favor of #20858
Thanks anyway for your work @Babacooll !

@nicolas-grekas nicolas-grekas modified the milestones: 3.x, 3.3 Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants