[Form] Fix FormDataCollector #20762
Merged
[Form] Fix FormDataCollector #20762
+123
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add test covering the bug to prevent regressions ? |
|
No, I can't... This code is a maze... |
|
Well, you said you had a reproducer. Couldn't it be used as a test ? |
|
It's a functional test with master + sub requests + profiler enabled. ie. a heavy stack... |
|
I can confirm that the patch works. |
Padam87
added a commit
to Padam87/symfony
that referenced
this pull request
Dec 5, 2016
|
I've added a failing test, which is fixed by this patch |
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 6, 2016
This PR was merged into the 3.2 branch. Discussion ---------- [Form] Fix FormDataCollector | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20698 | License | MIT | Doc PR | - Alternative to #20707 Commits ------- 50400c4 [Form] Add failing test for data collector bug 164a20c [Form] Fix FormDataCollector
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #20707