[Validator] Fix caching of constraints derived from non-serializable parents #20793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows to still cache constraints even when an uncachable constraint (i.e. Callback) is added to a parent class at runtime. This is achived by caching only the constraints that are loaded for the class in question only and merging parent and interface constraints after reading from cache.
|
The Travis error looks related to your patch. |
|
Had only PHP 5.5 to test locally ... |
|
Oh dear, to early in the morning to spot the same two lines further down ... |
2 tasks
xabbuh
reviewed
Dec 31, 2016
| return $this->loadedClasses[$class] = $metadata; | ||
| } | ||
|
|
||
| private function mergeConstraints(ClassMetadata $metadata) |
There was a problem hiding this comment.
I think I would use a name like mergeConstraintFromParentClasses().
|
@uwej711 The change itself looks good to me. However, this will only solve the issue mentioned in #12302 (comment), right? |
|
looks good to me. 👍 |
|
👍 |
|
Thank you @uwej711. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 12, 2017
…rializable parents (uwej711) This PR was squashed before being merged into the 2.7 branch (closes #20793). Discussion ---------- [Validator] Fix caching of constraints derived from non-serializable parents | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12302 | License | MIT | Doc PR | - This change allows to still cache constraints even when an uncachable constraint (i.e. Callback) is added to a parent class at runtime. This is achived by caching only the constraints that are loaded for the class in question only and merging parent and interface constraints after reading from cache. Commits ------- 9dd6b0c [Validator] Fix caching of constraints derived from non-serializable parents
This was referenced Jan 12, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to still cache constraints even when an uncachable constraint (i.e. Callback)
is added to a parent class at runtime.
This is achived by caching only the constraints that are loaded for the class in question only
and merging parent and interface constraints after reading from cache.