Skip to content

[HttpKernel][Console?] Fix script exit code when throwing Error #20797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpKernel][Console?] Fix script exit code when throwing Error #20797

wants to merge 1 commit into from

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #20775
License MIT
Doc PR N/A

I'm not sure that's the proper way to fix it, but I don't have any better idea 😕

@ogizanagi ogizanagi mentioned this pull request Dec 7, 2016
Closed
@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Dec 7, 2016
@ogizanagi ogizanagi mentioned this pull request Dec 14, 2016
Closed
@ogizanagi
Copy link
Contributor Author

Is there anything else we could do here?
This related issue seems pretty critical to me.

@fabpot
Copy link
Member

fabpot commented Mar 22, 2017

Closing as I've tested and it has been fixed since then.

@fabpot fabpot closed this Mar 22, 2017
@ogizanagi ogizanagi deleted the fix/2.7/console_php7_error_script_exit_code branch March 22, 2017 18:19
@ogizanagi ogizanagi mentioned this pull request Mar 22, 2017
Closed
@Jean85
Copy link
Contributor

Jean85 commented Mar 23, 2017

Maybe this should be reopened, since @fabpot reopened the issue?

@chalasr
Copy link
Member

chalasr commented Mar 23, 2017

I confirm this is still relevant, the bug exists only using the full-stack framework.

@ogizanagi ogizanagi restored the fix/2.7/console_php7_error_script_exit_code branch March 23, 2017 22:14
@ogizanagi ogizanagi mentioned this pull request Mar 23, 2017
Closed
@ogizanagi
Copy link
Contributor Author

Reopened in #22134

@ogizanagi ogizanagi deleted the fix/2.7/console_php7_error_script_exit_code branch April 13, 2017 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpKernel Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@ogizanagi @fabpot @Jean85 @chalasr @nicolas-grekas @carsonbot