Add a --show-arguments flag to the debug:container command #20861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about inline service definitions? (ie when |
chalasr
reviewed
Jan 2, 2017
| foreach ($this->getArgumentNodes($argument, $dom) as $childArgumenXML) { | ||
| $argumentXML->appendChild($childArgumenXML); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
As pointed out, there should be something like:
} elseif ($argument instanceof Definition) {
$argumentXML->setAttribute('type', 'service');
}
|
Comments are addressed and PR is green (failures look unrelated) Ping @dunglas |
|
👍 |
|
Thank you @Cydonia7. |
fabpot
added a commit
that referenced
this pull request
Jan 12, 2017
…mand (Cydonia7) This PR was merged into the 3.3-dev branch. Discussion ---------- Add a --show-arguments flag to the debug:container command | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | not yet This PR adds a `--show-arguments` flag to the `debug:container` command that shows arguments in the services in the different available formats. (Ping @dunglas) Commits ------- 5c151d0 Add a --show-arguments flag to the container debug command
|
This doesn't work for single service description, covered in #21290. |
fabpot
added a commit
that referenced
this pull request
Jan 15, 2017
… missing cases (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Fix debug:container --show-arguments missing cases | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20861 (comment) | License | MIT | Doc PR | n/a Fixes the new `--show-arguments` option for per-service describing (i.e. `debug:container foo_service --show-arguments`, doesn't work at all right now). Commits ------- 57b17f4 [FrameworkBundle] Fix debug:container --show-arguments missing cases
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--show-argumentsflag to thedebug:containercommand that shows arguments in the services in the different available formats.(Ping @dunglas)