Minor fixes for 3.2 #20870
Merged
Minor fixes for 3.2 #20870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
commented
Dec 11, 2016
| @@ -31,8 +31,8 @@ public static function castStub(Stub $c, array $a, Stub $stub, $isNested) | |||
| $stub->attr = $c->attr; | |||
|
|
|||
| if (Stub::TYPE_REF === $c->type && !$c->class && is_string($c->value) && !preg_match('//u', $c->value)) { | |||
| $stub->type = self::TYPE_STRING; | |||
| $stub->class = self::STRING_BINARY; | |||
| $stub->type = Stub::TYPE_STRING; | |||
There was a problem hiding this comment.
This one looks like an actual bug fix however.
Ping @nicolas-grekas: I didn't see any related test covering this. 😕
|
👍 |
|
👍 Status: Reviewed. |
|
👍 |
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2016
This PR was merged into the 3.2 branch. Discussion ---------- Minor fixes for 3.2 | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A This only fix minor issues in the codebase introduced in 3.2. Refs: - YamlEncoder 9366a7d - File helper: d9a8499 - VarDumper ClassStub: 788f7e8 - Cache tag based invalidation 19764af - CacheWarmer for Serializer: 810f469 - SymfonyStyle simplified test: 85e5060 - Workflow Definition builder: ffaeba3 --- There are other issues in older branches, but I guess it's not worth it for them, as it'll only add more conflicts. But for 3.2, it should be feasible. Commits ------- 7bdfc84 Minor fixes for 3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only fix minor issues in the codebase introduced in 3.2.
Refs:
YamlEncoder 9366a7d
File helper: d9a8499
VarDumper ClassStub: 788f7e8
Cache tag based invalidation 19764af
CacheWarmer for Serializer: 810f469
SymfonyStyle simplified test: 85e5060
Workflow Definition builder: ffaeba3
There are other issues in older branches, but I guess it's not worth it for them, as it'll only add more conflicts. But for 3.2, it should be feasible.